Added job attribute to Evidence Artifacts object. #1130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dave McCormack <[email protected]>
davemcatcisco
requested review from
floydtree,
pagbabian-splunk,
Aniak5,
mikeradka and
zschmerber
as code owners
floydtree
previously approved these changes
Jun 28, 2024
Signed-off-by: Dave McCormack <[email protected]>
|
@mikeradka and @floydtree - I had to resolve conflicts that had arisen and this dismissed your previous reviews. Can you please re-approve. @pagbabian-splunk, @Aniak5, and @zschmerber - I need one more approver. This PR has been open for several weeks waiting for another approver. I'd be most grateful if one of you could do the needful. |
mikeradka
approved these changes
Jul 16, 2024
floydtree
approved these changes
Jul 16, 2024
Aniak5
approved these changes
Jul 18, 2024
|
Thanks, all. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue:
#1124
Description of changes:
jobattribute to theEvidence Artifactsobject.at_least_oneconstraint in the object to includejob.Note that this approach is the same as that taken to fix other gaps in the
Evidence Artifactsobject, e.g. PR #1078.